Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Add feature switches for conditional vendoring of dependencies #2744

Closed
CyberTailor opened this issue May 3, 2024 · 1 comment
Closed
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@CyberTailor
Copy link

Is your feature request related to a problem? Please describe.

webauthn-rs-core crate is not comptaible with LibreSSL (see kanidm/webauthn-rs#402) and fails to build against it. OpenSSL 1.1 is also unsupported.

Describe the solution you'd like

Add a feature switch to depend on openssl/vendored.

Describe alternatives you've considered

Fix build with LibreSSL or make WebAuthn functionality optional (controlled with a feature switch).

Additional context

A feature switch controlling vendoring libsqlite3-sys could also be added.

@CyberTailor CyberTailor changed the title Add feature switches for conditional vendoring of dependencies build: Add feature switches for conditional vendoring of dependencies May 3, 2024
@yaleman yaleman added enhancement New feature or request good first issue Good for newcomers labels May 3, 2024
@Firstyear
Copy link
Member

You already can build this with cargo build --features openssl/vendored (but if I recall, vendored openssl is still 1.1 for some reason).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
Status: ✅ Done
Development

No branches or pull requests

3 participants