Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set custom image/icon for applications #2056

Open
yaakov-h opened this issue Sep 3, 2023 · 4 comments · May be fixed by #2665
Open

Set custom image/icon for applications #2056

yaakov-h opened this issue Sep 3, 2023 · 4 comments · May be fixed by #2665
Labels
api REST API things enhancement New feature or request internals Deep wizardry kanidmd Server-side things uwu ✧・゚: *✧・゚♡*(ᵘʷᵘ)*♡・゚✧*:・゚✧

Comments

@yaakov-h
Copy link

yaakov-h commented Sep 3, 2023

Is your feature request related to a problem? Please describe.

It would be nice to set a custom image/icon for each app (e.g. oauth2 integrations) that shows up on the web interface to replace the default crab mascot.

This may or may not be relevant to #1996 or #1955.

Describe the solution you'd like

Perhaps something like:

kanidm system oauth2 set-logo appname https://example.com/image.svg

Describe alternatives you've considered

I could print the icon on a post-it note and stick it over the top of the default image on my screen. 😁

@yaleman
Copy link
Member

yaleman commented Sep 3, 2023

The main issue I can see with specifying a third-party URL is that our existing content security policies don't allow for it - we would need to cache/store it locally for display - which I'd prefer we did for performance and consistency reasons.

There's also the matter of size/format etc which becomes its own nuisance across different user devices.

@yaleman yaleman mentioned this issue Sep 3, 2023
10 tasks
@yaleman yaleman added enhancement New feature or request uwu ✧・゚: *✧・゚♡*(ᵘʷᵘ)*♡・゚✧*:・゚✧ internals Deep wizardry kanidmd Server-side things api REST API things labels Sep 3, 2023
@Firstyear
Copy link
Member

Yeah, I don't think I'd be comfortable with a third party url here. i'd rather have kani serve the blob, which would give us a lot more control about replication and serving this reliably.

@ToxicMushroom
Copy link
Collaborator

ToxicMushroom commented Mar 15, 2024

required args are surrounded by <>.

Would kanidm system oauth2 set-image <name> </path/to/local/file.svg> <imagetype> be a good interface to handle this ?
It think it'd just need to send the post to /v1/oauth2/{:rs_name}/_image.
We will need to update:

  • the user applist webui to try to show the icons
  • the internals to advertise the /ui/images/oauth2/{:rs_name} endpoints inside AppLink::Oauth2 objects
  • preferably lazy load the images ?

lmk if I missed something.

@yaleman
Copy link
Member

yaleman commented Mar 16, 2024

You shouldn't have to set image type, but the CLI command matches what I'd expect.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api REST API things enhancement New feature or request internals Deep wizardry kanidmd Server-side things uwu ✧・゚: *✧・゚♡*(ᵘʷᵘ)*♡・゚✧*:・゚✧
Projects
Status: 📋 Backlog
Development

Successfully merging a pull request may close this issue.

4 participants