Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clearly document panic cases #2

Open
kangalio opened this issue Jul 12, 2020 · 6 comments
Open

Clearly document panic cases #2

kangalio opened this issue Jul 12, 2020 · 6 comments

Comments

@kangalio
Copy link
Owner

No description provided.

@lucemans
Copy link

Im wondering if there is a specific reason for panicking when encountering an unexpected midi value

image

other => panic!("Unexpected midi message: {:?}", other),

For context: this is the launchpad mini (mk1), with the example version inquiry code from readme

@lucemans
Copy link

Hmm it appears [128, x, 64] is sent by the launchpad on release of a button, where X = 0 for the most topleft gridbutton
x = 16 for the first button the row below, etc

@kangalio
Copy link
Owner Author

Cc @belak who contributed Launchpad Mini support in #3

Yeah 128 = 0x80 is the status code for a MIDI note off message. In the code it explained there is no handler for note off messages because the Launchpad doesn't use it... which is evidently false in this case

@lucemans
Copy link

Happy to make a PR where possible. I currently have a semi-patched version on lucemans/launchy.

Also working on mini mk3 support, but after some testing it has proven to be a lot more difficult seeing it has "scenes" and ableton specific things built in by default.

@lucemans
Copy link

Created an issue with my findings so far related to the mini mk3

Looking forward to working on this!
#12

@belak
Copy link
Contributor

belak commented Dec 23, 2023

Interesting. I'm not sure why I didn't run into this when I was working on LP Mini support. I can try and take a look in the next few days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants