-
-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Flashes black on start for a split second #423
Comments
Hi there! I cannot reproduce this on my end. Maybe my system is too fast 😜 Anyways, if you are willing to run the latest version from git, you could experiment with different window types. For this, replace this line with either Else we could maybe try some other workarounds. Here, a fix using opacity is mentioned. Maybe you could add an |
Normal: animates from a smaller black window to full window opacity 0: no effect??? I could reproduce this on an amd iGPU system, nvidia 2060 system and the intel system I am writing from. So it's weird that you can't see that |
Although, after further testing, this appears to be only correlated with the cpu speed |
I've just seen that the opacity does nothing on Linux. So much to this idea. I am currently running Kando on KDE in a virtual machine and even there I see no flickering... Here are some more ideas what you could do for testing:
|
If I am not misreading |
How did you take those measurements? Is this a profile of Kando's startup (before opening a menu)? Or is it the first time a menu is opened? I think we should focus rather on the cases where the menu is opened a second or a third time in the same session. The very first time could take a bit longer as some resource will be allocated then. But all subsequent menu-openings should be fast. Here is how I looked at this on my end: 0001-2770.mp4As you can see, the first frame after showing the menu takes a bit more time than the later frames but at most we dropped one frame here... |
Btw, have you tried building a release version of Kando ( |
Yes, this also happens with github binaries. out.mp4 |
The menu-loading time scales about linearly with the amount of menu items. I looked at the DOM tree creation code and was able to significantly optimize it. Below are my timings of the
Even 400 items are pretty unrealistic in real-world applications, but this is a nice speedup anyways. I guess that it will improve the situation on your end as well! However, even with these very long loading times, I did not observe any flickering! Maybe some other theme settings are interfering here? I was using KDE Neon from a Live-ISO in Virtualbox for testing. The timings above are from my real GNOME session, the timings in the VM were about twice as long in all cases. If you want to, you could try the latest |
Running off of the latest main is indeed a little faster. But there is still flickering. I even tried it on a new user, nothing changed. I am going to try the vm now |
Ok, can't reproduce in a vm (neon user/testing and arch gnome/kde) :( Edit: disabled, still there.... I give up, this is black magic, updating electron to 30 didn't help either |
You could try to reproduce it with a minimal example. I just created this gist which you can simply import into Electron Fiddle. If you hit the Run-button, a transparent window will pop up. If this flickers as well, it's close to an electron bug... |
While doing some random stuff I noticed that kando is starting under xwayland, is that expected? And the test does work, no flicker: Screencast_20240516_203553.webm |
Setting ozone platform to wayland gets rid of the flicker, but the menu is also gone)) |
Could you also set
Yeah, that's Electron's default mode on Wayland. At least on GNOME it works okayishly with |
Alredy tried, no flicker
Yoooo, this WORKED I think this is indeed either an electron bug or electron on xwayland bug |
Cool! But still weird that it does not happen in the VM. And I am aware of several other KDE users and they do not seem to have this issue either. So let's close this issue for now? Maybe someone else shows up with the same issue and than we can reopen it and try to narrow down potential reasons... |
Yes, sounds good to me. Thanks for the quick help! |
Screencast_20240514_090007.webm
When activating kando I get a brief black flash, this is more prominent with system under some load, but also happens when it's idle (for a shorter period though).
I am using kde 6.0.4 / qt 6.7 on arch with wayland
The text was updated successfully, but these errors were encountered: