Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a task name to the web notifications list (instead of just a #id - as it is now) #5456

Open
temp5mr opened this issue Apr 24, 2024 · 4 comments

Comments

@temp5mr
Copy link

temp5mr commented Apr 24, 2024

I just slightly adjusted the code in templates\web_notifications\show.php and we all really liked it. Perhaps it's not the most correct approach, but it would be great to have such a feature properly implemented.
This part:

        <span class="table-list-title">
            <?php if ($this->text->contains($notification['event_name'], 'subtask')): ?>
             ...
            <?php endif ?>

			<?php if (isset($notification['event_data']['task']['project_name'])): ?>
				<?= $this->url->link(
					$this->text->e($notification['event_data']['task']['project_name']),
					'BoardViewController',
					'show',
					array('project_id' => $notification['event_data']['task']['project_id'])
				) ?> &gt;
			<?php elseif (isset($notification['event_data']['project_name'])): ?>
				<?= $this->text->e($notification['event_data']['project_name']) ?> &gt;
			<?php endif ?>

			<?php
			
			if (isset($notification['event_data']['task'])):
				$taskID = $notification['event_data']['task']['id'];
				$taskTitle = $notification['event_data']['task']['title'];

				if ($this->text->contains($notification['event_name'], 'task.overdue') && count($notification['event_data']['tasks']) > 1):
					echo "Задача #$taskID: $taskTitle"; 
				else:
					echo $this->url->link(
						"Задача #$taskID: $taskTitle",
						'WebNotificationController',
						'redirect',
						array('notification_id' => $notification['id'], 'user_id' => $user['id'])
					); 
				endif;
			endif;
			?>
        </span>
@tomeli5n
Copy link

Hello,

This week I made a plugin to show this detail to the user.

https://github.com/tomeli5n/NotifyPlus

@fguillot
Copy link
Member

Feel free to submit a pull-request. It's probably better to have this enhancement directly in Kanboard instead of having an external plugin.

@h-e-l-l-o-w-o-r-l-d
Copy link

h-e-l-l-o-w-o-r-l-d commented Apr 26, 2024

In my opinion the user notifications are the weakest point in Kanboard, Most of our users don't use it because information is too basic, important things are missing and it's not grouped by task which is not practical at all. On the other hand, information via email is not collected either but sent on the fly. Just nobody likes to get 7 mails within 5 minutes. So we were a bit lost here.

Because of this and because no plugin existed, I also started to code a notification plugin 1 week ago, so I was a bit shocked to see this now. :o) I don't like the idea of having 2 plugins for the same purpose, but looking at your Plugin, my version is more advanced with all information you can think of like column changes, highlighted mentions and so on. Also, it is closer to the core.

So I will continue and finish it, which will take approx 2-3 weeks. My plan was to release it on Github and ask @fguillot if he would prefer a pull-request after trying it out.

I also planned the mentioned (optional) functionality "collect information and send it via email every x hours or daily", but I'm not sure yet how to properly implement it.

Stay tuned

@tomeli5n Looking at the screenshots... which CSS-plugin do you use to have such nice and clean styles?

@tomeli5n
Copy link

tomeli5n commented Apr 26, 2024

@tomeli5n Looking at the screenshots... which CSS-plugin do you use to have such nice and clean styles?

ThemeRevision Theme

Anyway, the notifications section of my plugin still needs some design work. I will work to try to make an official PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

4 participants