Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support git submodules #75

Open
epcim opened this issue May 5, 2017 · 4 comments
Open

support git submodules #75

epcim opened this issue May 5, 2017 · 4 comments

Comments

@epcim
Copy link

epcim commented May 5, 2017

if repo has submodules, the commits are not found

@randomize
Copy link

randomize@5b3677f
Simplest possible solution to add 'git submodule foreach', but perhaps a more sophisticated one would be updating .git directory search algorithm so it doesn't ignore submodule dirs (they have .git as file instead of dir).

@jlewin
Copy link

jlewin commented Mar 13, 2019

Really excited to see this tool exists, bummed to learn it ignores submodules

@mihaicris
Copy link

mihaicris commented Apr 5, 2020

I found that commenting all these lines will show the commits from submodules:
For a strange reason, this condition evaluates to TRUE and skips the submodule commits.
You need to pass -F though.
git standup -F -d 3 -m 2

# continue if not a git directory
#  if [[ ! -d ".git" || -f ".git" ]] ; then
#   cd ${BASE_DIR}
#    continue
#  fi

Later edit: I am on macOS Catalina, using GNU bash, version 3.2.57(1)-release (x86_64-apple-darwin19)

@ghost
Copy link

ghost commented Apr 30, 2021

Issue still exists in master. Applying the patch in #116 seems to fix it for me. Were there some other issues with the PR that made you close it @mihaicris ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants