Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Instructions for Play production mode only didn't work for me #117

Open
ctoomey opened this issue Jun 25, 2021 · 2 comments
Open

Instructions for Play production mode only didn't work for me #117

ctoomey opened this issue Jun 25, 2021 · 2 comments

Comments

@ctoomey
Copy link

ctoomey commented Jun 25, 2021

When following the instructions, after sbt disting and then running Play (in production mode), there were no metrics reported via the Prometheus exporter web page.

Actually there were a few kamon metrics, but not the hundreds of akka metrics I got otherwise when using the SBT Kanela Runner Plugin, in both dev and production mode.

I noticed in the dist-generated start script, there was no -javaagent: JVM argument provided, which I'm guessing is the problem since I understand you're using the aspectj agent to do the instrumentation. Seems the instructions are thus missing the needed step of adding this to build.sbt: javaAgents += "org.aspectj" % "aspectjweaver" % "1.9.6" % "runtime".

@ctoomey
Copy link
Author

ctoomey commented Jun 25, 2021

Update: adding this to build.sbt: javaAgents += "org.aspectj" % "aspectjweaver" % "1.9.6" % "runtime" didn't get it to work in production mode either.

Please let me know how to enable production mode only.

@ivantopo
Copy link
Contributor

Hey @ctoomey, thanks for bringing this up. I'll update that guide ASAP!

We are not using AspectJ since Kamon 2.x. The new agent is our own Kanela agent 😄. The right dependency to add would be javaAgents += "io.kamon" % "kanela-agent" % "1.0.11". More info here.

Please let me know if that fixes it for you. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants