Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow to pull superschema with hive:fetch based on schema checks #4089

Open
comatory opened this issue Feb 26, 2024 · 2 comments
Open

allow to pull superschema with hive:fetch based on schema checks #4089

comatory opened this issue Feb 26, 2024 · 2 comments

Comments

@comatory
Copy link
Contributor

comatory commented Feb 26, 2024

This is a suggestion to augment hive:fetch command, or possibly introduce an alternative way to pull in superschema which contains changes to subschema which has not been published yet. It is a little bit similar to this but my use-case is not for local development but for CI automation.

In some cases, I'd like to construct superschema on a PR branch, take the superschema and run it through Relay compiler in our front-end codebase to be absolutely sure we won't break anything. (FYI we had issue where we approved changes to subschema which renamed enum members, it seemed to be ok but then it failed during runtime because of FE usage).

Allowing to run hive:fetch with commit SHA that maps to a version in schema checks would solve my problem.

@kamilkisiela
Copy link
Owner

Maybe something like this?
#2437

@comatory
Copy link
Contributor Author

Maybe something like this? #2437

@kamilkisiela yep that sounds like something that would work for us. You can mark this one as duplicate / related and close it. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants