Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Non accurate DFXP subtitles. #1483

Open
tomstolarczuk opened this issue Oct 29, 2023 · 1 comment
Open

Non accurate DFXP subtitles. #1483

tomstolarczuk opened this issue Oct 29, 2023 · 1 comment

Comments

@tomstolarczuk
Copy link

Hello!
We've noticed that WebVTT captions are a bit misaligned compared to what is declared in original XML file. Looking at the dfxp_format.c parser code, it defines framerate as constant 30fps (DFXP_FRAME_RATE). Are there any plans to support different framerates (eg. by reading ttp:frameRate property)?

Also: do you accept PRs?

Greetings,
Tom
@tomstolarczuk tomstolarczuk changed the title Non accurate DFXP subtitles. Non accurate TTML subtitles. Oct 30, 2023
@tomstolarczuk tomstolarczuk changed the title Non accurate TTML subtitles. Non accurate DFXP subtitles. Oct 30, 2023
@erankor
Copy link
Contributor

erankor commented Nov 2, 2023

This makes sense, I think I just wasn't familiar with this property when I wrote this... a PR is welcome

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@erankor @tomstolarczuk