Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

False positive: This statement seems to be disconnected from its parent foreach. #1924

Open
inDeev opened this issue Dec 18, 2023 · 5 comments

Comments

@inDeev
Copy link

inDeev commented Dec 18, 2023

Subject Details
Plugin Php Inspections (EA Extended) 5.0.0.0
Language level PHP 8.2

Current behaviour

Snímek obrazovky 2023-12-18 v 8 07 02

Expected behaviour
No alert shown

@martineiber
Copy link

I had the same Issue. Reported here:
https://youtrack.jetbrains.com/issue/QD-7094/It-is-not-a-problem-EA-This-statement-seems-to-be-disconnected-from-its-parent-foreach.

@PetrKaterinak
Copy link

This EA looks too dificult for me. In my opinion it is almost not possible to know what exactly affects something out of foreach scope. This EA should be removed, I'm seeing it often and in some cases it helped to me, but in global perspective it has more false positives than true.

@kalessil
Copy link
Owner

kalessil commented Dec 18, 2023

@ea-inspections-team: this inspection is receiving a lot of complaints. Can you disable it by default in the next release please?

@ea-inspections-team
Copy link
Collaborator

ea-inspections-team commented Feb 4, 2024

@kalessil: yes, we will disable it by default.

@inDeev: is addRow a part of any OSS package, or it is a proprietary code base? We would like to research a bit on false-positives vs pure/tinted methods and functions.

@inDeev
Copy link
Author

inDeev commented Feb 4, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants