Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

False positive message to delete the method, as the parent method is identical #1917

Open
Crovitche-1623 opened this issue Nov 9, 2023 · 0 comments

Comments

@Crovitche-1623
Copy link

Subject Details
Plugin Php Inspections (EA Extended)
Language level PHP 8.2

Current behaviour

A false positive message indicate to drop the method as it's identical to the parent one but it's not true as there is an additional PHP Attribute:
image

<?php
// App\Entity\SlugTrait.php

trait SlugTrait
{
    // ...
    protected ?string $slug = null;

    public function getSlug(): ?string
    {
        return $this->slug;
    }
    // ...
}

Expected behaviour

Do not report this message if there is an additional / different PHP Attribute comparing to the parent method / method in trait.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant