Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Class static used to pass info between stream steps #12

Open
jukkakarvanen opened this issue Mar 29, 2019 · 4 comments
Open

Class static used to pass info between stream steps #12

jukkakarvanen opened this issue Mar 29, 2019 · 4 comments

Comments

@jukkakarvanen
Copy link
Contributor

Kafka_Streams_TensorFlow_Image_Recognition_Example use class static variables to pass information between foreach and mapValues steps.

So I expect rather interesting problems if executed with multiple threads.

I have fix for this, but it is on top of changes related to #11

@jukkakarvanen
Copy link
Contributor Author

Similar problems noticed also in other classes.

@kaiwaehner
Copy link
Owner

kaiwaehner commented Apr 3, 2019

Yeah, to be honest, my first implementation was "quick and dirty", also I am not coding daily anymore - thus, I forgot some best practices about Java coding in last years :-)

Thank you so much for these improvements and pull requests.

@kaiwaehner
Copy link
Owner

I merged your fix. Thank you.

I will keep the ticket open as reminder for the other classes. I will refactor the other classes, too.

@hamzakhalil798
Copy link

@jukkakarvanen
Hey! im a newbie at this... im trying to run this repo using mvn clean package. Do I have to use kafka as well? or just use mvn clean package and everything would run?
kindly help me out on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants