Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pcf: big endian not supported #534

Open
armijnhemel opened this issue Sep 15, 2021 · 0 comments
Open

pcf: big endian not supported #534

armijnhemel opened this issue Sep 15, 2021 · 0 comments

Comments

@armijnhemel
Copy link
Collaborator

PCF files can be both little endian and big endian. The specification in KS currently hardcodes that it is little endian, yet doesn't check for big endian files. At least for the Python code this is leading to big memory consumption (because of the way that code for repeatexpr` is generated).

A simple dirty fix would be to disallow big endian files and bail out, the correct way would be to support both.

The simple fix is here:

armijnhemel/binaryanalysis-ng@b00f6ae#diff-07c692af304bcd5effb9469ea4040c5a64432e5ac5706c196f087c23c708e98f

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant