Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validating initialLocale before using it #217

Merged
merged 5 commits into from Sep 3, 2023
Merged

Validating initialLocale before using it #217

merged 5 commits into from Sep 3, 2023

Conversation

marekdedic
Copy link
Contributor

@marekdedic marekdedic commented Jun 27, 2023 •
edited

Hi,
this PR fixes #209.

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR relates to an outstanding issue, so please reference it in your PR, or create an explanatory one for discussion. In many cases features are absent for a reason.
  • This message body should clearly illustrate what problems it solves. If there are related issues, remember to reference them.
  • Ideally, include a test that fails without this PR but passes with it. PRs will only be merged once they pass CI. (Remember to npm run lint!)

Tests

  • Run the tests tests with npm test or yarn test

@marekdedic marekdedic changed the title Added a test with an invalid initial locale Validating initialLocale before using it Sep 1, 2023
@marekdedic marekdedic mentioned this pull request Sep 1, 2023
Open
kaisermann
kaisermann approved these changes Sep 3, 2023
View reviewed changes
Copy link
Owner

@kaisermann kaisermann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay, thanks!

@kaisermann kaisermann merged commit ebeec58 into kaisermann:main Sep 3, 2023
1 of 2 checks passed
@marekdedic marekdedic deleted the invalid-initial-locale branch September 3, 2023 13:32
@marekdedic
Copy link
Contributor Author

I actually only submitted the fix a few days ago, so no problem :) Thanks!

@kaisermann
Copy link
Owner

Released as 3.7.1 🙏

@brunnerh brunnerh mentioned this pull request Sep 3, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaisermann kaisermann kaisermann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Interpolation doesn't work with invalid initialLocale
2 participants
@marekdedic @kaisermann