Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: added azure and gcs cache integration guide #91

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

amitamrutiya
Copy link
Contributor

Closes #90

πŸ“‘ Description

In this pull request, I've implemented all the necessary steps to configure other cache providers as well.

βœ… Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

β„Ή Additional Information

Merging this PR in one go might be challenging, so please don't hesitate to point out any mistakes or suggest enhancements. Your feedback is greatly appreciated.

Signed-off-by: amitamrutiya2210 <amitamrutiya2210@gmail.com>

Signed-off-by: amitamrutiya2210 <amitamrutiya2210@gmail.com>
Copy link

netlify bot commented Feb 15, 2024

βœ… Deploy Preview for meek-marigold-103c48 ready!

Name Link
πŸ”¨ Latest commit f12ddef
πŸ” Latest deploy log https://app.netlify.com/sites/meek-marigold-103c48/deploys/65cd90156b495a000864e487
😎 Deploy Preview https://deploy-preview-91--meek-marigold-103c48.netlify.app
πŸ“± Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@@ -38,7 +38,80 @@ _Removing the Remote Cache_:
If users wish to remove the remote cache without deleting the associated AWS S3 bucket, they can use the following command:

```
k8sgpt cache remove --bucket <name>
k8sgpt cache remove
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

users don't need to specify the resource?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, without specifying any resource, it will select the current active cache and convert it into a file-based cache. I have also checked the K8sGPT code and confirmed that there are no other flags present like --bucket on the cache remove command.


To view the items stored in the remote cache, users can use the following command:

```g
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove g

Users can add a remote cache to the K8sGPT CLI by executing the following command:

```
k8sgpt cache add --azure --storage <azure storage account name> --container <container name>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add where to find both the and the container
It might be obvious but better to be 100% clear which information we need here

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, here, could you please add what the user is supposed to see once they have run the command?

### Prerequisites
Before using the remote caching feature with Google Cloud Storage in K8sGPT, ensure you have the following prerequisites set up:

- `GOOGLE_CLOUD_STORAGE_ACCOUNT`: An Google Cloud Storage Account is required to authenticate with gcloud CLI programmatically.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once I run the K8s GPT command that will trigger the authentication with the the glcloud CLI?

k8sgpt cache add --gcs --bucket --region --projectid

Could we add a verification step -- e.g. describing in a few words what users are supposed to see?

If users wish to remove the remote cache without deleting the associated Azure Blob Storage container, they can use the following command:

```
k8sgpt cache remove
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add what the user is supposed to see e.g. is there a confirmation message?

Copy link
Member

@AnaisUrlichs AnaisUrlichs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let a few minor comments, thank you for the work :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: Documentation Missing Cache Provider
2 participants