feat: support RISC-V 64 #297
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shanduur
force-pushed
the
riscv64-support
branch
4 times, most recently
from
000288a
to
246a78f
Compare
dereknola
requested changes
May 30, 2024
|
Why are you changing the code at all? This should just build as-is on riscv64.
I don't think we want that... what is wrong with using cgo on riscv64? |
Signed-off-by: Mateusz Urbanek <mateusz.urbanek.98@gmail.com>
|
Yeah, agreed @brandond. I reverted the code changes, now it's just the rv64 platform support. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I do not fully understand how the Dapper scripts work, but build works, so should be good?
How I tested it:
make ARCH=riscv64 docker run \ --rm --interactive --tty \ --volume=./bin/:/mnt/bin \ --platform=linux/riscv64 \ riscv64/busybox \ /mnt/bin/kineCloses #296