Skip to content
This repository has been archived by the owner on Mar 31, 2021. It is now read-only.

Migration to Reakit v1 #84

Closed
2 of 6 tasks
jxom opened this issue Jun 5, 2019 · 1 comment
Closed
2 of 6 tasks

Migration to Reakit v1 #84

jxom opened this issue Jun 5, 2019 · 1 comment

Comments

@jxom
Copy link
Owner

jxom commented Jun 5, 2019

Reakit v1 was released a few weeks ago now, so I think it would be nice to start to think about migrating from v0 to v1.

See the Reakit v1 migration guide here

I anticipate that this migration will be an incremental migration, starting with the Fannypack foundation, then moving to a per-component basis.

Here is the Reakit v1 branch

Below are the high-level steps to achieving the migration:

Foundation

  • Install Reakit v1 on an aliased package (reakit-next@npm:reakit@beta)
  • Add in the Reakit v1 Provider
  • Use styled-components independently
    • NOTE: We will probably migrate to styled-components once v0 is fully out, and still depend on reakit/styled in the meantime.
  • Utility to wrap a Reakit component with reset styling, CSS props & spacing/color/font style overrides.

Primitives

  • Create a Box component
    • Wraps around Reakit v1's Box
    • The reason why we won't directly export Reakit v1's Box is because it now doesn't come with reset styles, inbuilt CSS props & Fannypacks spacing/color overrides.
  • Create Block, InlineBlock, Inline, Flex, InlineFlex, Grid components
    • These primitives are now removed in Reakit v1
    • It will use Fannypack's Box

Typography

TODO

Layout

TODO

Components

TODO

Form

TODO

Utilities

TODO

Templates

TODO

@jxom jxom pinned this issue Jun 5, 2019
@jxom
Copy link
Owner Author

jxom commented Aug 22, 2019

Closing in favour of #92

@jxom jxom closed this as completed Aug 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant