Skip to content
This repository has been archived by the owner on Mar 31, 2021. It is now read-only.

Styling/theming of Select and SelectMenu #51

Open
hastebrot opened this issue Feb 19, 2019 · 1 comment
Open

Styling/theming of Select and SelectMenu #51

hastebrot opened this issue Feb 19, 2019 · 1 comment

Comments

@hastebrot
Copy link
Contributor

The icon of Select components can't be changed.

screenshot 2019-02-19 at 13 27 47

The Select component of a SelectMenu ignores theme configuration.

screenshot 2019-02-19 at 13 28 13

@hastebrot
Copy link
Contributor Author

hastebrot commented Feb 19, 2019

My plan is to allow replacement of <Icon /> via a new prop.

// Select.tsx
{isLoading ? <LoadingSpinner color="text" /> : <Icon />}

Maybe there should also be an icon property in the Select theme options.

Same applied to SelectMenu:

// SelectMenu.tsx
{isLoading ? <SelectMenuLoadingSpinner color="text" /> : <SelectIcon />}

Additionally SelectMenu should be themed using SelectMenu.Select theme option or Select theme option.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant