Skip to content
This repository has been archived by the owner on Mar 31, 2021. It is now read-only.

WIP: (feature) Allow MenuGroup title prop to be a ReactElement. #52

Closed
wants to merge 1 commit into from
Closed

WIP: (feature) Allow MenuGroup title prop to be a ReactElement. #52

wants to merge 1 commit into from

Conversation

hastebrot
Copy link
Contributor

@hastebrot hastebrot commented Feb 19, 2019 •
edited

work in progress. do not merge

This lets the TypeScript compiler output an error.

Type '{ children: Validator<string | number | boolean | {} | ReactElementLike | ReactNodeArray>; title: Requireable<string | ReactElementLike>; }' is not assignable to type 'WeakValidationMap<MenuGroupProps>'.
  Types of property 'title' are incompatible.
    Type 'Requireable<string | ReactElementLike>' is not assignable to type 'Validator<string | (string & ReactElement<any>) | null | undefined>'.ts(2322)

Fixes #48.

@hastebrot hastebrot requested a review from jxom as a code owner February 19, 2019 21:12
@jxom jxom closed this Jun 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jxom jxom Awaiting requested review from jxom jxom is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow title prop of Menu.Group to be PropTypes.element.
2 participants
@hastebrot @jxom