Skip to content
This repository has been archived by the owner on Mar 31, 2021. It is now read-only.

Switches changing colour? #37

Open
kochie opened this issue Jan 3, 2019 · 3 comments
Open

Switches changing colour? #37

kochie opened this issue Jan 3, 2019 · 3 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@kochie
Copy link

kochie commented Jan 3, 2019

The colours on the switch seem to change to the default theme when clicked.
fannypack_switch
You can see it in the docs

@jxom
Copy link
Owner

jxom commented Jan 3, 2019

Hey @kochie,

This is expected, as the Switch gains focus when it is clicked, triggering the focus outline. This is important for accessiblity. This is also evident with input fields. However, maybe we should make this a bit clearer? Adding a focus outline (of the same colour - maybe a lighter variant?) around the state outline could be a better solution... Thoughts?

@kochie
Copy link
Author

kochie commented Jan 3, 2019

Yeah, that seem reasonable, I would expect that the focus colour for the switch would be the same as the switch colour or lighter as it's a bit jarring.

@jxom jxom added enhancement New feature or request good first issue Good for newcomers labels Jan 3, 2019
@terencehuynh
Copy link
Contributor

Lighter/darker variant of the same colour would be nice - especially given we have associated the colours with meanings (i.e. red for danger, yellow for warning).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants