Skip to content
This repository has been archived by the owner on May 10, 2023. It is now read-only.

onChange not being triggered for CheckboxGroup and SwitchGroup #98

Open
harsilspatel opened this issue Jan 20, 2021 · 3 comments
Open

onChange not being triggered for CheckboxGroup and SwitchGroup #98

harsilspatel opened this issue Jan 20, 2021 · 3 comments
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@harsilspatel
Copy link

To Reproduce
Playroom links for SwitchGroup and CheckboxGroup.
@harsilspatel harsilspatel changed the title onChange not being triggered for CheckboxGroup and SwitchGroup onChange not being triggered for CheckboxGroup and SwitchGroup Jan 20, 2021
@jxom
Copy link
Owner

jxom commented Jan 20, 2021

Hmm, yeah, seems like it doesn't get invoked for an uncontrolled group... However it does if you make it controlled (add a value prop)
https://bumbag.style/playroom/#?code=N4Igxg9gJgpiBcIA8BhAFjMBrARhAHgOIBOEArgA4A6AdgAR00CGAtjALxUgDuMTALhmJdaDCBX4BLCDQDO7YAG1RDOsDoAbJjhgb4dAOQBlMjRoBPAwBo6ANyYayMfQdmmLBugF8rKhuq0dPUMAdUkaKEsbe0dnQ25wyM8fPzVNbV0XAHlbGGIwJll%2BazsHJxcIXPzC4u8VAF0vFRl0JhoAcw5gAAoASjp2AD46SDkIDRgAOg0Idu6uFrQ2zq5epvpS2IVXd0t1gHpBkC8gA

@jxom
Copy link
Owner

jxom commented Jan 20, 2021

Do you need the onChange handler for an uncontrolled input group?

@harsilspatel
Copy link
Author

Thanks for the prompt reply! No worries, I'll have them as controlled input.

And since we're talking, do you mind fixing this to SelectMenu?: SelectMenuThemeConfig;?

@jxom jxom added bug Something isn't working good first issue Good for newcomers labels Feb 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jxom @harsilspatel