Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider to accept "pathes" as part of an Id of RootStores #780

Open
Lysander opened this issue Aug 7, 2023 · 0 comments
Open

Consider to accept "pathes" as part of an Id of RootStores #780

Lysander opened this issue Aug 7, 2023 · 0 comments
Labels
discussion Extra attention is needed enhancement New feature or request
Milestone

Comments

@Lysander
Copy link
Collaborator

Lysander commented Aug 7, 2023

Currently the path property of a RootStore is always the empty String.

This might be wrong in cases, where you want to manage the mapped portion of some larger model-store within a separate local store.

Because of the current behavior, one looses the capabilities of the automatic validation message mapping of the headless components, which relies on the store.path property.

Imho we can simply "pathify" some given Id, by splitting it with substringAfter(".", "") with empty String as missing delimiter value. This way we bypass API breaking, as long as noone has ever used Ids with "dots" inside (which we should definitely explain and demand in an upcoming revise of the validation section of our documentation). So imho this could be considered "none API breaking" and solve this corner case quite elegantly.

@Lysander Lysander added enhancement New feature or request discussion Extra attention is needed labels Aug 7, 2023
@haukesomm haukesomm added this to the 1.0-RC18 milestone Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion Extra attention is needed enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants