Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Page titles containing "&" are not properly URL-encoded #65

Open
slavagrn opened this issue Aug 4, 2021 · 1 comment
Open

Page titles containing "&" are not properly URL-encoded #65

slavagrn opened this issue Aug 4, 2021 · 1 comment
Labels

Comments

@slavagrn
Copy link

slavagrn commented Aug 4, 2021

The & symbol and everything after it disappears when you press the Go! button. For example, if one of the pages in the search is S&P Global Ratings, the text in the input field changes to just S.

@jwngr jwngr added the bug label Aug 5, 2021
@jwngr
Copy link
Owner

jwngr commented Aug 5, 2021

Thanks for the report. It's amazing this bug hasn't come up before! Looks like the page names need to be URL-encoded before being thrown into the URL.

To be honest, this project is in maintenance mode for me, so I'm unlikely to fix this. If someone wants to put together a PR with a fix, I'd be happy to test and deploy it though.

@jwngr jwngr changed the title A bug with page titles containing “&” Page titles containing "&" are not properly URL-encoded Aug 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants