Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests fail on 1.11 #179

Open
KristofferC opened this issue Apr 18, 2024 · 1 comment
Open

Tests fail on 1.11 #179

KristofferC opened this issue Apr 18, 2024 · 1 comment

Comments

@KristofferC
Copy link

┌ Info: Running IR test in a subprocess...
│   cmd = `/Users/kristoffercarlsson/julia1.11/usr/bin/julia -C native -J/Users/kristoffercarlsson/julia1.11/usr/lib/julia/sys.dylib --depwarn=yes --check-bounds=yes -g1 --color=yes --startup-file=no --startup-file=no --color=yes --check-bounds=no --code-coverage=none --inline=yes`
└   script = "/Users/kristoffercarlsson/JuliaPkgs/Setfield.jl/test/perf.jl"
heads_lens = [:call, :call, :call, :call, :call, :call, :call, :call, :call, :new]
heads_hand = [:call, :call, :call, :new]
IR: Test Failed at /Users/kristoffercarlsson/JuliaPkgs/Setfield.jl/test/perf.jl:83
  Expression: uniquecounts(heads_lens) == uniquecounts(heads_hand)
   Evaluated: Dict(:call => 9, :new => 1) == Dict(:call => 3, :new => 1)

A comment in the test says that this test might be too strict. But maybe there is a regression in some optimization that used to happen here.

@jw3126
Copy link
Owner

jw3126 commented Apr 18, 2024

probably makes sense to manually inspect @btime and @code_*

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants