Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bidi brings older version of ring-core into projects; should it be :scope "provided"? #182

Open
timothypratley opened this issue May 11, 2018 · 1 comment

Comments

@timothypratley
Copy link
Contributor

Including bidi as a dependency can break handlers that are expecting a higher version of ring-core:
taoensso/sente#322

Should the ring-core dependency be :scope "provided" to avoid this?

@SevereOverfl0w
Copy link
Contributor

For setting the scope to provided in leiningen, a profile is preferred (https://github.com/technomancy/leiningen/blob/master/doc/PROFILES.md#default-profiles mentions this briefly).

I agree ring-core should be in :provided scope, as it's not necessary in order to use bidi at all.

timothypratley added a commit to timothypratley/bidi that referenced this issue Jun 1, 2018
Including bidi as a dependency can break handlers that are expecting a higher version of ring-core: taoensso/sente#322
Resolves issue: juxt#182 Bidi brings older version of `ring-core` into projects; should it be :scope "provided"?
malcolmsparks pushed a commit that referenced this issue Jun 4, 2018
Including bidi as a dependency can break handlers that are expecting a higher version of ring-core: taoensso/sente#322
Resolves issue: #182 Bidi brings older version of `ring-core` into projects; should it be :scope "provided"?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants