Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a more generic docker image #22

Open
justone opened this issue May 8, 2016 · 5 comments
Open

Create a more generic docker image #22

justone opened this issue May 8, 2016 · 5 comments

Comments

@justone
Copy link
Owner

justone commented May 8, 2016

From @gesellix:

Hey, I made a combined image for personal use, but it might help you to build a more generic variant. I also stumbled over some dynamic library issues when running a dockviz release in an Alpine image (using musl libc instead of glibc), which is why I build the binary during the Docker build.

See https://github.com/gesellix/docker-tree-viz for the source.

@justone
Copy link
Owner Author

justone commented May 8, 2016

What would be needed in a more generic image?

@gesellix
Copy link

gesellix commented May 8, 2016

As you can see in https://github.com/gesellix/docker-tree-viz/blob/master/viz.sh I use some dirty script hacking to handle the different options dockviz supports. Apart from the knowledge the shell script needs about dockviz, the main issue from my perspective is that you cannot easily provide images via stdin anymore.
Maybe it would be nice to add an option to dockviz which allowed to "post process" its result by calling another executable. That would minimize the need to wrap dockviz in a shell script. Such a feature should obviously be optional. Then, without the wrapper script, passing input via stdin would become easier again.

@gesellix
Copy link

gesellix commented May 8, 2016

I guess a first step to a more generic dockviz image would be to change the base image from scratch to something like alpine or similar. Alpine would be nice, because their package manager/repository already provides most utilities you and others might need, which consequently makes a dockviz image suitable as base image for more specific use cases.

@justone
Copy link
Owner Author

justone commented May 8, 2016

Makes sense. Thanks for explaining your use case.

I'll see what I can do.

@gesellix
Copy link

gesellix commented May 8, 2016

Though I'm no Golang expert, I'd be happy to help by providing PRs if you like :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants