Skip to content
This repository has been archived by the owner on Dec 4, 2017. It is now read-only.

Streamline log() and outputToLog() #6

Open
drance opened this issue Oct 16, 2015 · 0 comments
Open

Streamline log() and outputToLog() #6

drance opened this issue Oct 16, 2015 · 0 comments
Assignees

Comments

@drance
Copy link
Collaborator

drance commented Oct 16, 2015

The ObjC AspenHelpers currently log without the handy emoji prefixes. This is because that formatting is done in the private outputToLog() function, which ObjC can't call. Rather than make outputToLog() public so ObjC can see it, suggest (review with @justin):

  • remove outputToLog(), and rewrite verbose(), info(), etc. to call LogFormatter directly. This saves a method call and autoclosure capture / alloc per log statement, and isolates the implicit nature of the formatter to the convenience methods
  • remove the unused logger param from LogFormatter.formatLog()
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant