Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore order of query params #651

Open
drewburlingame opened this issue Sep 29, 2023 · 4 comments
Open

Ignore order of query params #651

drewburlingame opened this issue Sep 29, 2023 · 4 comments
Labels
feature-request A request for new functionality

Comments

@drewburlingame
Copy link

Is your feature request related to a problem? Please describe.

We have urls generated by a 3rd party framework and the order some query params are added is not always deterministic.

It would be helpful if the matcher was able to determine if query params were the same when not added in the same order.

Describe the solution you'd like

Ideally this would just work. If there's concern of introducing a breaking change, consider adding a property like HttpClientInterceptorOptions.IgnoreQueryParamOrder.

The matcher would split the query string into parts before comparing.

Describe alternatives you've considered

I created a custom matcher to do this, but I don't want to copy that code into every solution that uses this package and it seems silly to create a custom nuget just for that.

@drewburlingame drewburlingame added the feature-request A request for new functionality label Sep 29, 2023
@martincostello
Copy link
Member

This sounds reasonable - would you like to submit a PR with a proposed implementation?

@drewburlingame
Copy link
Author

I can do that. With my current bandwidth restrictions it will likley be a few weeks before I will get to it.

@silkfire
Copy link

silkfire commented Mar 6, 2024

@drewburlingame Any status on this? Would have been really useful.

@drewburlingame
Copy link
Author

@silkfire no progress. We ended up using a slightly different approach before I could get to this and it's now a low priority. I don't know when or if I'll be able to work on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request A request for new functionality
Projects
None yet
Development

No branches or pull requests

3 participants