Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Add OpenTelemetry Support #874

Open
slang25 opened this issue Mar 24, 2021 · 3 comments
Open

[Feature Request] Add OpenTelemetry Support #874

slang25 opened this issue Mar 24, 2021 · 3 comments
Labels
good-first-issue Issues that are great for first timers! help-wanted up-for-grabs
Milestone

Comments

@slang25
Copy link
Member

slang25 commented Mar 24, 2021

It would be great if out of the box JustSaying used ActivitySource that ships with .NET 5 (and the System.Diagnostics.DiagnosticsSource package for other TFMs).

See here:
https://devblogs.microsoft.com/dotnet/opentelemetry-net-reaches-v1-0/#library-authors

@slang25 slang25 added up-for-grabs good-first-issue Issues that are great for first timers! labels Mar 24, 2021
@stale
Copy link

stale bot commented Jul 21, 2021

This issue has been automatically marked as stale because it has not had any recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale
Copy link

stale bot commented Apr 16, 2022

This issue has been automatically marked as stale because it has not had any recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Apr 16, 2022
@martincostello martincostello added this to the Future milestone Jul 6, 2022
@slang25
Copy link
Member Author

slang25 commented Feb 13, 2023

I've been giving this some thought and think that we should make progress on this issue soon.
I'm thinking having an extra default middleware that does the ActivitySource goodness is the way to go, we already have an extensibility point for metrics, so could optionally add an out-of-the-box implementation of that too.

It would be cool to add use of AWSXRayPropagator (see here) but I'm hesitant to add a dependency to the main JustSaying package. Could we do this with extensible enrichment and a separate package? Would like peoples thoughts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good-first-issue Issues that are great for first timers! help-wanted up-for-grabs
Projects
None yet
Development

No branches or pull requests

3 participants