Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the behaviour clear when providing a Service URI #1113

Open
adammorr opened this issue Jan 18, 2023 · 1 comment
Open

Make the behaviour clear when providing a Service URI #1113

adammorr opened this issue Jan 18, 2023 · 1 comment

Comments

@adammorr
Copy link
Contributor

adammorr commented Jan 18, 2023

JustSaying allows you to provide a SerivceURI through the fluent API and DefaultAwsClientFactory which is then passed down to the underlying AWS SNS / SQS clients.

This is great for testing as it allows you to use libraries like LocalStack, however, there is a subtle behaviour change in that any region provided will be ignored by the AWS clients if a ServiceURI is provided and visa versa (see AWS client config).

To avoid consumers of JustSaying falling into this trap, we should look to surface this information in the public API somewhere so that it is clear what the behaviour is.

@yfesenko
Copy link

yfesenko commented Apr 16, 2024

This was a really tricky and time consuming thing to be trapped by. Would be nice if it is better documented (or have the sample app(s) have comments to highlight this)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants