Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support deserialization of arbitrary payloads #1003

Open
gkinsman opened this issue Apr 28, 2022 · 1 comment
Open

Support deserialization of arbitrary payloads #1003

gkinsman opened this issue Apr 28, 2022 · 1 comment
Milestone

Comments

@gkinsman
Copy link
Contributor

gkinsman commented Apr 28, 2022

The goal of this issue is to be able to handle non-JustSaying event payloads.

Possible implementations

  1. Add a implementation of IMessageSerializer that supports cloud events and deserializes into a JustSaying.Models.Message. Downsides include consumers consuming a JustSaying Message even though the input is a cloud event.

  2. Revisit removing Message base type and removing the link between Subject and Type to determine which serializer to use.

  3. Add new API to specify a subject and serializer tuple. When a message arrives, find the serializer by subject, and use that to produce a MessageWithAttributes. Serializers would be created per registration.

  • Bigger change than 1, not as big as 2
@martincostello martincostello added this to the v7.0.0 milestone Apr 28, 2022
@martincostello martincostello added this to To do in JustSaying v7.0.0 via automation Apr 28, 2022
@martincostello martincostello modified the milestones: v7.0.0, Future Jul 6, 2022
@martincostello martincostello removed this from To do in JustSaying v7.0.0 Jul 6, 2022
@NavaneeswarManam
Copy link

#944 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants