Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Email target should only get notified on transition to error state #15

Open
AnthonySteele opened this issue Jan 24, 2017 · 2 comments
Open
Labels

Comments

@AnthonySteele
Copy link
Contributor

Email target should only get notified on transition into error state, and not on transition into Ok state, as the pagerduty email trigger can't tell them apart and makes false alarms.

@tomhaigh says in #3:

We could create an SNS topic for each type of notification target - i.e. an email one (containing all email subscriptions) and a url one (with all url subscriptions) for each alerting group. That would mean we could restrict what types of notification go to each type of target without additional configuration.

The alternative is to stop supporting email alerts. But they are useful for trialing so rather keep them.

@AnthonySteele AnthonySteele changed the title Email target should only get notified on transition into error state Email target should only get notified on transition to error state Jan 24, 2017
@AnthonySteele
Copy link
Contributor Author

This now works for services made in cloudformation (i.e. all but DynamoDb tables, SQS Queues)

@tomhaigh
Copy link
Contributor

tomhaigh commented Mar 7, 2018

Should we close this now as the plan is to use CloudFormation for everything?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants