Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

version name in mod directory #29

Open
hahoyer opened this issue Dec 20, 2020 · 6 comments
Open

version name in mod directory #29

hahoyer opened this issue Dec 20, 2020 · 6 comments

Comments

@hahoyer
Copy link

hahoyer commented Dec 20, 2020

When I create a modpackage the top directory has the modversion at the end of the name. This is actually no longer necessary and makes developing and debugging the mod more difficult. Is there a setting to change this?

@justarandomgeek
Copy link
Owner

packaging is not involved in debugging, this question makes no sense

@hahoyer
Copy link
Author

hahoyer commented Mar 1, 2021

Just asking if you could change function BuildZip in vscode-factoriomod-debug/src/ModPackageProvider.ts
into :

public static async BuildZip(moddir:string,packagepath:string,ignore:string[],name:string,version:string): Promise<number> { const zipoutput = fs.createWriteStream(packagepath); const archive = archiver('zip', { zlib: { level: 9 }}); archive.pipe(zipoutput); archive.glob("**",{ cwd: moddir, root: moddir, nodir: true, ignore: ignore },{ prefix: ``${name}`` }); const bytesWritten = new Promise<number>((resolve,reject)=>{ zipoutput.on("close",()=>resolve(archive.pointer())); archive.finalize(); }); return bytesWritten; }

@hahoyer
Copy link
Author

hahoyer commented Mar 2, 2021

It's not about debugging itself, it's about the things around it.
If I want to debug a mod, I have to unpack it. If that's a different directory for each version, it's cumbersome. Either I still have to rename it each time or VSCode doesn't recognize that it's the same project.

@justarandomgeek
Copy link
Owner

why is it packed in the first place if you're still debugging it? develop it in place as an unpacked folder in mods

@hahoyer
Copy link
Author

hahoyer commented Mar 2, 2021

Oh, of course I debug and modify mods that I didn't develop myself. I thought that is clear and almost all work this way.
But apparently this is not true.
If it is apparently only my interest, then I can patch the place after each release. No need to change the product for that.

@hahoyer
Copy link
Author

hahoyer commented Mar 2, 2021

Actually a lot of mods in the mod portal are not using the version-name in the prefix parameter anymore. Maybe you can think about it again and change it one day. It's really only a very small change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants