Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

This needs to be published to NPM. #5

Open
marshallswain opened this issue Feb 8, 2014 · 5 comments
Open

This needs to be published to NPM. #5

marshallswain opened this issue Feb 8, 2014 · 5 comments

Comments

@marshallswain
Copy link

Great work! This really needs to be on NPM.

I know that it's MIT licensed, but it seems polite to ask, first. :)

If you don't want to, I can. I'll just need to add a package.json file and make it 'require'-able. Or I can submit a pull request with the changes... Just let me know.

@zippy1981
Copy link
Member

@marshallswain You are welcome to do it and I will accept a pull request. I just have one question. This is entirely designed to be run from a browser. Are there npms for clientside javascript libraries?

@marshallswain
Copy link
Author

Yes.  Package managers like webpack and browserify have made them more popular.

Have a great day!

Marshall Thompson

On February 21, 2014 at 8:36:44 AM, Justin Dearing (notifications@github.com) wrote:

@marshallswain You are welcome to do it and I will accept a pull request. I just have one question. This is entirely designed to be run from a browser. Are there npms for clientside javascript libraries?


Reply to this email directly or view it on GitHub.

@mkrn
Copy link

mkrn commented Oct 29, 2014

So what's the status of putting it up on npm?
Really want to try it out
Thanks!

@marshallswain
Copy link
Author

I figured out afterward that you can just use npm install [github repo address] to pull directly from your repository.  Try it out.

Have a great day!

Marshall Thompson

On Wed, Oct 29, 2014 at 11:48 AM, Mark Sergienko notifications@github.com
wrote:

So what's the status of putting it up on npm?
Really want to try it out

Thanks!

Reply to this email directly or view it on GitHub:
#5 (comment)

@mkrn
Copy link

mkrn commented Nov 1, 2014

Hey @marshallswain I tried it but then realized that the module had straight using "document" in it so I hacked it around to add browser-checking and then use node's process.pid when it's used on node..

However that didn't work and I've put it off.

I think it would be huge to create a small universal module to use on client and node, because using
var ObjectID = require("bson/lib/bson/objectid").ObjectID
is polluting browserify build...

@imlucas imlucas self-assigned this Nov 12, 2014
@imlucas imlucas removed their assignment Mar 7, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants