Skip to content
This repository has been archived by the owner on Dec 3, 2019. It is now read-only.

Conversation

jkoritzinsky
Copy link

Ignore warnings in binary logs from Xamarin.iOS failing to connect to a Mac. These warnings are common in CI builds but are not always actionable. Additionally, they are only issued from within targets shipped in MSBuild and are not directly influenced by user code.

Currently, these errors crash BCC-MSBuildLog since they occur outside of the source tree.

Fixes #26.

@jkoritzinsky
Copy link
Author

@StanleyGoldman one of the checks you have marked as expected (continuous-integration/appveyor/branch) will only happen for PRs from this repository.

@codecov
Copy link

codecov bot commented Dec 30, 2018

Codecov Report

Merging #27 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master      #27      +/-   ##
==========================================
+ Coverage   99.77%   99.77%   +<.01%     
==========================================
  Files          10       10              
  Lines         439      447       +8     
==========================================
+ Hits          438      446       +8     
  Misses          1        1
Impacted Files Coverage Δ
src/BCC.MSBuildLog/Services/BinaryLogProcessor.cs 100% <100%> (ø) ⬆️

@StanleyGoldman
Copy link
Member

Hey @jkoritzinsky sorry for the late late reply.
I've been refactoring this library to work as a build logger and submit automatically at the end.
That will make it a lot easier to use and require a lot less configuration on the users part.
Thanks for the help. I've yet to work out appropriate testing for these changes. So I'm not sure how your work will apply.

@StanleyGoldman one of the checks you have marked as expected (continuous-integration/appveyor/branch) will only happen for PRs from this repository.

I'm not used to getting pull requests from other people. I'll fix that.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Warnings from MSBuild Tasks crash BCC-MSBuildLog
2 participants