Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI breaking issue in landscape printing #1457

Open
ryankwondev opened this issue Apr 11, 2024 · 1 comment
Open

UI breaking issue in landscape printing #1457

ryankwondev opened this issue Apr 11, 2024 · 1 comment
Labels
bug status: ready to implement Issues that can be actively worked on, and need an implementation!

Comments

@ryankwondev
Copy link

Hi, I've noticed an issue in JTD where the UI breaks when printing a document via Cmd+P in my browser.

  • Chrome Version 123.0.6312.107 Arm Official Build
  • M1 Mac Pro

Portrait:
Screenshot 2024-04-11 at 3 10 08 PM

Landscape:
Screenshot 2024-04-11 at 3 10 22 PM

I'm guessing it has something to do with print.scss, but I'm a backend engineer and don't see the direct relevance to CSS. I need help.

@mattxwang
Copy link
Member

Hi @ryankwondev, thank you for submitting an issue! I appreciate the detail that makes it easier to reproduce this issue, and confirm that I can reproduce this live.

I also don't know exactly what the error is right now, but upon first glance it looks like the header is getting reproduced on every landscape page, while it is not in portrait - this explains the overlap. No red flags jump out to me in the code, so I'd need to dig deeper.

I'm happy to add this to my backlog, but given our limited resources in maintenance it may be a while until I get to properly investigating and fixing this. I'd be happy to review a PR that investigates and resolves this issue. Thank you again for noticing this issue!

@mattxwang mattxwang added the status: ready to implement Issues that can be actively worked on, and need an implementation! label Apr 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug status: ready to implement Issues that can be actively worked on, and need an implementation!
Projects
None yet
Development

No branches or pull requests

2 participants