Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo #7

Open
Jakob-Unfried opened this issue Nov 29, 2023 · 1 comment
Open

Typo #7

Jakob-Unfried opened this issue Nov 29, 2023 · 1 comment

Comments

@Jakob-Unfried
Copy link

Hi Juraj,

I was just reading your SVD code for reference on how people do the SVD backward pass.
I found a typo at

if (gv is None) and (gv is None):

where you dont check gu is None but instead gv is None twice.
Just FYI =)

@jurajHasik
Copy link
Owner

Thanks ! Fortunately its in the variant of the backward, which is not used (and should be just deleted from master)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants