Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

polish / cleanup this repo #2

Open
DerThorsten opened this issue Oct 20, 2021 · 12 comments
Open

polish / cleanup this repo #2

DerThorsten opened this issue Oct 20, 2021 · 12 comments

Comments

@DerThorsten
Copy link
Collaborator

@jtpio I cleaned up the Dockerfile, but I assume it does not make sense to add further changes here before we have the "common" code (https://github.com/jupyterlite/xeus-kernel/tree/experiments) ready

@jtpio
Copy link
Member

jtpio commented Oct 20, 2021

Right. We should make the CI pass on this repo first anyway.

@DerThorsten
Copy link
Collaborator Author

@jtpio ci is passing, should we put it on PyPi?

@jtpio
Copy link
Member

jtpio commented Oct 20, 2021

Sure. I can create an empty jupyterlite-xeus-wren package on PyPI as a placeholder so we can generate tokens for it.

Then we could use the releaser to publish it there.

@jtpio
Copy link
Member

jtpio commented Oct 20, 2021

@DerThorsten I can do the initial release, but will need write access to the repo for that

@DerThorsten
Copy link
Collaborator Author

you should have an invitation @jtpio

@jtpio
Copy link
Member

jtpio commented Oct 20, 2021

Thanks!

@DerThorsten
Copy link
Collaborator Author

@jtpio there is also https://github.com/DerThorsten/jupyter_wren_syntax to have some syntax highlighting for wren. There is a conda-forge PR, but unfortunately it builds only for mac and win....oddly it does not run on linux and fails with a conda unsatisfiable dependency error
but for jupyerlite we can live without a conda package. I assume we would need to put this on npm to use this in the juyterlite kernel

@jtpio
Copy link
Member

jtpio commented Oct 20, 2021

Or we also publish that package to PyPI.

Looks like this is a JupyterLab prebuilt / federated extension so it should also work out of the box in JupyterLite.

@jtpio
Copy link
Member

jtpio commented Oct 20, 2021

Or we also publish that package to PyPI.

In that case we can do something similar:

@jtpio
Copy link
Member

jtpio commented Oct 21, 2021

jupyterlite-xeus-wren is live on this custom JupyterLite deployment: https://jtpio.github.io/lit

image

@DerThorsten
Copy link
Collaborator Author

awesome!
Should we use this for the blogpost or rather have one jupyterlite with everything?

@jtpio
Copy link
Member

jtpio commented Oct 21, 2021

I think they could be added to https://github.com/jupyterlite/demo.

Will look into releasing jupyterlite-xeus-lua next. We can do the refactor with the common xeus code later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants