Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide a theme toggle plugin by default #124

Open
martinRenou opened this issue Jan 23, 2024 · 0 comments
Open

Provide a theme toggle plugin by default #124

martinRenou opened this issue Jan 23, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@martinRenou
Copy link
Member

martinRenou commented Jan 23, 2024

Problem

As suggested in pydata/pydata-sphinx-theme#745 (comment)

@jtpio just linked this in another thread https://jupyterlite.readthedocs.io/en/stable/howto/configure/advanced/iframe.html

It showcases an example making a jupyterlite plugin allowing to set the theme from outside of the iframe.

We could provide such a plugin by default in jupyterlite-sphinx, allowing pydata-sphinx-theme to notify jupytelite iframes of a potential theme change.

Not only We could support setting the theme using a theme name, but the message could probably also contain css variable values as a dictionary.

@martinRenou martinRenou added the enhancement New feature or request label Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant