Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Database API in GitHubManager to handle larger files #71

Open
yyykt opened this issue Feb 24, 2022 · 2 comments
Open

Use Database API in GitHubManager to handle larger files #71

yyykt opened this issue Feb 24, 2022 · 2 comments
Labels
enhancement New feature or request

Comments

@yyykt
Copy link

yyykt commented Feb 24, 2022

Problem

Currently, GitHubManager uses Contents API to obtain file diffs from GitHub. Since this API only supports files up to 1 MB, the following error was displayed when I tried to review a notebook with some image outputs.

Load File Error (Invalid response: 403 This API returns blobs up to 1 MB in size. The requested blob is too large to fetch via the API, but you can use the Git Data API to request blobs up to 100 MB in size.)

Proposed Solution

I think this situation can be solved by using Database API instead, which supports blobs up to 100 MB.

Additional context

@yyykt yyykt added the enhancement New feature or request label Feb 24, 2022
@welcome
Copy link

welcome bot commented Feb 24, 2022

Thank you for opening your first issue in this project! Engagement like this is essential for open source projects! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please try to follow the issue template as it helps other other community members to contribute more effectively.
welcome
You can meet the other Jovyans by joining our Discourse forum. There is also an intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

@bollwyvl
Copy link
Contributor

Sure, this sounds good to investigate. Note, of course, that a lot of visual features start to break down with assets of large size when viewed in the browser, so anything that starts to get close to that 100mb is not going to feel very responsive...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants