Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minimal Interesting Binder #35

Open
bollwyvl opened this issue Mar 13, 2021 · 1 comment
Open

Minimal Interesting Binder #35

bollwyvl opened this issue Mar 13, 2021 · 1 comment

Comments

@bollwyvl
Copy link
Contributor

Having a binder that does... anything... would be really useful.

Once #29 is good to go, I'll be happy to do the work to add a read-only AnonGitHubManager which would let you at least look at something (until you ran out of requests).

Some deltas here:

  • this manager would require a starting point (e.g. a specific org or repo)
    • but we probably want that anyway
  • carefully managing n+1 queries (don't list files/discussions until needed)
    • probably need to do that anyway
  • add a Router endpoint that avoids many queries and gets you to the good stuff

From a re-use perspective, if all a project had to do was...

# requirements.txt
jupyterlab-pullrequests
# diff-match-patch

And then a binder URL so that, e.g. jupyterlab/jupyterlab PR 1234 was:

GET https://mybinder.org/v2/gh/jupyterlab/jupyterlab/HEAD?urlpath=lab/prs/agh/jupyterlab/jupyterlab/1234

...to bop you right into the PR overview. That could then happily grab the list of files and the discussion, and you would most likely be able to view a lot of what you needed before you hit the budget.

@bollwyvl
Copy link
Contributor Author

bollwyvl commented Apr 8, 2021

I'm planning to take a go at this, hopefully should have something up soon!

@bollwyvl bollwyvl moved this from To do to In progress in Roadmap for JupyterLab Pull Requests Apr 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant