Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR summary enhancements #24

Open
fcollonval opened this issue Mar 8, 2021 · 1 comment
Open

PR summary enhancements #24

fcollonval opened this issue Mar 8, 2021 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@fcollonval
Copy link
Member

  • in the PR summary,
    • the chat messages could be a lot more condensed and probably don't need any border at all, nor are extra layout colors needed...
    • the PR source/target repo and key (this could be the link instead of the View Details button,
      • e.g. [octocat]jupyterlab/pull-requests#16)
        • the provider could hoist this SVG instead of cooking it into the typescript build
    • the proposer (also with a link to their page)
    • a tall tree or wide miller columns of the files that are actually in that pr that open the tear-aways, with better metadata than +/-
      • the file browser is just going to need a lot of work, and really needs first-class, first-party support, potentially via that datagrid merged cell PR on lumino (think i mentioned above)
    • the "start a new discussion" box could always be visible, and stuck to the bottom of the tab
      • making it automatically scale to what you're writing would be fly, but a SplitPanel would be fine, too
    • i don't know if the "reply" on a past message makes much sense, unless the provider actually supports them (GH sure doesn't, buh)
    • i'd expect too see the why changing metadata in the summary, with a link to open that diff you are seeing

Originally posted by @bollwyvl in #16 (comment)

@fcollonval fcollonval added enhancement New feature or request good first issue Good for newcomers labels Mar 8, 2021
@fcollonval
Copy link
Member Author

a tall tree or wide miller columns of the files that are actually in that pr that open the tear-aways

Some users gave feedback it is surprising not seeing the modified files when clicking on the PR description panel.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Development

No branches or pull requests

1 participant