Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nbdime diff algorithm... not quite like Myers algorithm #22

Open
fcollonval opened this issue Mar 8, 2021 · 0 comments
Open

nbdime diff algorithm... not quite like Myers algorithm #22

fcollonval opened this issue Mar 8, 2021 · 0 comments
Labels
question Further information is requested

Comments

@fcollonval
Copy link
Member

Git diff is using Myers algorithm by default on raw text lines. Its output can be quite different compare to nbdime diff for notebooks. And therefore when creating new comment, it is not uncommon that upon reload the comment position changes.

This is especially true with GitLab that requires the line in the original and the new file to comment on an unmodified line.

@fcollonval fcollonval added the question Further information is requested label Mar 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

1 participant