Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor the plugins handling out of the Application #697

Open
fcollonval opened this issue Apr 12, 2024 · 5 comments · May be fixed by #703
Open

Refactor the plugins handling out of the Application #697

fcollonval opened this issue Apr 12, 2024 · 5 comments · May be fixed by #703
Labels
enhancement New feature or request

Comments

@fcollonval
Copy link
Member

Problem

The plugins are handled directly within the Application. This prevents the usage of plugins to initialize application attribute. The symptomatic case is the need to customize the service manager in JupyterLab.

Xref:

Proposed Solution

Extracting the plugin resolver logic in its own class (because why should such great feat be hard linked to the Application). Once we get that the logic in index.js will be:

  • Create the plugin resolver with all the plugins
  • Provide that resolver to the lumino Application

⚠️ we will need to expose the resolver method in the Application to ensure backward compatibility

Additional context

@jtpio
Copy link
Member

jtpio commented Apr 16, 2024

Thanks @fcollonval for opening the issue 👍

Linking to #586 as this may also help with this use case.

@jtpio
Copy link
Member

jtpio commented May 10, 2024

@fcollonval just checking if you had plans to look into this yourself, or if other contributors could also start looking into it?

@fcollonval
Copy link
Member Author

I started a branch. I hope to get a PR next week. Is it too late?

@fcollonval
Copy link
Member Author

@jtpio
Copy link
Member

jtpio commented May 10, 2024

OK great, thanks for starting this!

I just wanted to double check what the status on this was, to avoid double work in case someone would be interested in looking into this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants