Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Karma is deprecated we should move on #610

Open
fcollonval opened this issue Jul 17, 2023 · 4 comments · May be fixed by #704
Open

Karma is deprecated we should move on #610

fcollonval opened this issue Jul 17, 2023 · 4 comments · May be fixed by #704
Labels
maintenance Dependencies, build, technical debt, etc.

Comments

@fcollonval
Copy link
Member

Problem

Karma is deprecated

Proposed Solution

We should use more modern test tool; Jest is probably the best candidate to avoid yet another tool compared with JupyterLab.

@fcollonval fcollonval added enhancement New feature or request status:Needs Triage maintenance Dependencies, build, technical debt, etc. and removed enhancement New feature or request status:Needs Triage labels Jul 17, 2023
@krassowski
Copy link
Member

+1 to jest for simplicity

@fcollonval
Copy link
Member Author

Note: in jupyterlab-git we switched to the testing-library. I think it will be a good candidate for lumino widgets tests.

@krassowski
Copy link
Member

What is the selling point over jest?

@fcollonval
Copy link
Member Author

You still need jest as a test runner. The goal of the testing-library is to render components (of any framework) and interact with the DOM to carry out the user actions and introspect it for expectations.

Basically this is what is needed to replace karma while jest is to replace chai and mocha.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Dependencies, build, technical debt, etc.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants