Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The Title.changed signal could emit some detail about the change #553

Open
krassowski opened this issue Mar 12, 2023 · 0 comments
Open

The Title.changed signal could emit some detail about the change #553

krassowski opened this issue Mar 12, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@krassowski
Copy link
Member

krassowski commented Mar 12, 2023

Problem

In jupyterlab/jupyterlab#13676 (comment) we would like to filter out updates caused by tab switch, which changes className of tab title leading to the signal being emitted:

set className(value: string) {
if (this._className === value) {
return;
}
this._className = value;
this._changed.emit(undefined);
}

However, sine it is emitted with undefined, we cannot distinguish the cause of the change and filter out specific updates.

Proposed Solution

Change the signal to include the update information.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants