Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem with install in the build step #551

Closed
mlucool opened this issue Mar 5, 2020 · 2 comments
Closed

Problem with install in the build step #551

mlucool opened this issue Mar 5, 2020 · 2 comments

Comments

@mlucool
Copy link
Contributor

mlucool commented Mar 5, 2020

Having jlpm install in the package.json's build is somewhat problematic. I happened to have set NODE_ENV=production yarn run build, which yarn took to mean uninstall all my dev dependencies.

Not a high priority, but thought it was worth flagging.

@kgryte
Copy link
Member

kgryte commented Mar 10, 2020

@mlucool Not clear the problem in this case, given that yarn respected the NODE_ENV environment variable as discussed elsewhere, mirroring npm install behavior.

What were you wanting to have happen when setting NODE_ENV to production if not the installation of only dependencies and not development dependencies?

@mlucool
Copy link
Contributor Author

mlucool commented Mar 10, 2020

I expect that NODE_ENV=production yarn run build builds for production. This does not work because it uninstalls my build tools first (I don't have tsc globally installed) so it just errors.

fcollonval added a commit to fcollonval/jupyterlab-git that referenced this issue May 27, 2020
To have install + build, just execute `jlpm`
meeseeksmachine pushed a commit to meeseeksmachine/jupyterlab-git that referenced this issue May 28, 2020
fcollonval added a commit that referenced this issue May 28, 2020
…on-0.11.x

Backport PR #649 on branch 0.11.x (Fix #551)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants