Iconography updates

[weihwang]

Proposal to update iconography
https://www.figma.com/file/UyNpeQNuTj6Uv74MoEJDh3ji/Git-extension?node-id=606%3A1844

New actions:

• Push/Pull (pending feedback on Add push/pull actions #246)
• Add repo
• Diff
• Setting (possible future addition)

Updates:

• File status: updating from 3 letter icon to single letter higher contrast icons

All icons

Impact to commit change detail (related to #227)

Impact to file browser view (related to #124)

[dhirschfeld]

Looks awesome! Just a few comments which you can take or leave:

• The clone repo icon doesn't scream "clone" to me but I'm not sure anything is obviously better. Maybe some combination of the download/pull icon and the git icon?
  
• The discard trashcan icon seems a little alarming - i.e. might get confused for deleting the file rather than discarding the changes. An undo (rewind arrow) icon might be less alarming whilst conveying the same message
• The view diff icon is somewhat ambiguous but I'm also not sure what is better. Perhaps we could get away without a diff icon though if clicking on the file in the changes view automatically brought up the diff view. This is the behaviour of VSCode and something I really like about it. For me, being able to easily view/understand the changes which will be committed is critical so anything which lowers the barrier to that is great. If the diff view is brought up automatically when you click on a file (in the changes view) then it's one less click the user needs to do.

[weihwang]

@dhirschfeld great feedback, thanks! I saw another comment on the "delete/trashcan" so let me take a pass at the "undo" arrow.

On the diff action, if clicking on the filename and always showing the diff is reasonable, not just showing the file itself, I'll remove the diff icon proposal. This helps simplify the actions column too.

[jaipreet-s]

@weihwang We should also have a disabled state for the Clone git repo icon for the case when the clone button will be disabled if we are already inside a Git repo. (Subtask 3 in #253 )

[weihwang]

Added disabled git clone, undo. Removed "diff" since we can use the filename for the action.

[weihwang]

Added dark theme icons

[jaipreet-s]

@weihwang
An internal user reported that the Push icon was not intuitive. What's your take on this?

The “push” icon wasn’t obvious. It’s a small cloud with an up-arrow. o  Recommendation: Maybe something that looks more like a “Save” icon. I’m not great at UX but I know this took us a good 30 seconds to discover the existing icon even when we knew what we wanted to do.

[weihwang]

While I agree a save icon might be more intuitive, we need something that can support directional actions of push/pull, and save seems like it supports only one category. I've considered the upload/download but those icons are used for staging/unstaging at the moment. This will require some additional review.

[fcollonval]

@telamonian @kgryte should we close this rather all issues. And let people start new issues based on the latest styles.

[kgryte]

I am okay with closing this issue given recent changes.