Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to modified cell in the notebook from diff view #1128

Open
krassowski opened this issue May 27, 2022 · 0 comments
Open

Jump to modified cell in the notebook from diff view #1128

krassowski opened this issue May 27, 2022 · 0 comments

Comments

@krassowski
Copy link
Member

krassowski commented May 27, 2022

Is your feature request related to a problem? Please describe.

Viewing diffs of notebooks is very nice to narrow down what has changed, especially in long notebooks, however it does not enable one to immediately find the place in the editable instance of the notebook. When reviewing changes in a notebook, if I decide that I need to revert a change or fix a typo I need to scroll manually through the notebook/take time to find the location where the change occurred.

Describe the solution you'd like

I would like to be able to open the diffed notebook at the location of a selected change (scroll and switch focus if already open). It would make for a good right-click option on the added/changed/removed cells.

Describe alternatives you've considered

An alternative would be to make it even more granular (line-by-line) and that would then be also useful for diffs of text files, but it wouldn't be as useful - for text files I can quickly jump to the location by using "jump to line by number" function. In notebooks however cells do not have short memorable identifiers like line numbers so there is more benefit to have this for notebooks specifically.

Having this as a button which shows on hover over modified cell rather than context menu option could be more discoverable (but also more annoying for some users)

Additional context

  • Python package version:
  • Extension version:
  • Git version:
  • Operating System and its version:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant