Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JupyterLab's update notification button does nothing when inside JupyterLab Desktop #754

Open
telljmc opened this issue Jan 26, 2024 · 4 comments
Labels

Comments

@telljmc
Copy link

telljmc commented Jan 26, 2024

I installed JupyterLab Desktop app on MacOS Sonoma 14.2.1 using the MacOS installer several days ago. I just noticed a pop-up window in the bottom right corner notifying me that a new version is available. How do you install it?

I clicked on the notification pop-up expecting to see a button labeled "Apply update" but didn't. Then I opened each of the drop-down menus expecting to find it there but didn't. Then I read the documentation with no luck. Lastly, I searched through the issues but did not find anything that addressed this topic. I am sure it must have been covered somewhere and I missed it.

The closest thing I found is instructions to uninstall old versions before installing a new one. However, it seems unlikely that I should uninstall and reinstall every time there is an incremental release update.

Would someone be kind enough to point me to the documentation or describe how to apply updates?

Copy link

welcome bot commented Jan 26, 2024

Thank you for opening your first issue in this project! Engagement like this is essential for open source projects! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please try to follow the issue template as it helps other other community members to contribute more effectively.
welcome
You can meet the other Jovyans by joining our Discourse forum. There is also an intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

@JasonWeill JasonWeill added the bug label Jan 30, 2024
@JasonWeill
Copy link

@telljmc Thank you for opening this issue! I was running JupyterLab Desktop 4.0.7-1 on macOS 13, and I just opened the app for the first time in a while. I received this popup, which looks like a native macOS popup, asking me to restart to install an update:

image

Once I clicked "Restart" (twice), the app closed and reopened, having been updated.

Can you attach a screen shot of the behavior you're seeing? I suspect that you're seeing a notification from within JupyterLab's underlying environment, not from JupyterLab Desktop's update checker. This might be an opportunity for JupyterLab Desktop to override JupyterLab's behavior, to not allow the underlying environment's JupyterLab to check for updates from within the desktop app.

@JasonWeill JasonWeill changed the title How does one apply updates to the JupyterLab Desktop app? JupyterLab's update button doesn't do anything when run inside JupyterLab Desktop. Jan 30, 2024
@JasonWeill JasonWeill changed the title JupyterLab's update button doesn't do anything when run inside JupyterLab Desktop. JupyterLab's update button doesn't do anything when run inside JupyterLab Desktop Jan 30, 2024
@JasonWeill JasonWeill changed the title JupyterLab's update button doesn't do anything when run inside JupyterLab Desktop JupyterLab's update notification button does nothing when inside JupyterLab Desktop Jan 30, 2024
@mbektas
Copy link
Member

mbektas commented Feb 3, 2024

this #760 disables update notifications from web app. desktop app will handle updates separately as usual.

@JasonWeill
Copy link

Closing as fixed by #760. Thanks @mbektas !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants